8000 [Routing] Invokable route loader services by fancyweb · Pull Request #11333 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Routing] Invokable route loader services #11333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your 8000 account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2019
Merged

[Routing] Invokable route loader services #11333

merged 1 commit into from
Apr 7, 2019

Conversation

fancyweb
Copy link
Contributor
@fancyweb fancyweb commented Apr 7, 2019 •
edited
Loading

#eufossa

doc for symfony/symfony#30933

Also the notation with one column has been deprecated so I updated this part as well.

@fancyweb fancyweb mentioned this pull request Apr 7, 2019
Merged
2 tasks
@wouterj wouterj added ⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming Waiting Code Merge Docs for features pending to be merged labels Apr 7, 2019
@fancyweb fancyweb force-pushed the invokable-object-route-loader branch from a3d69dd to d9b4121 Compare April 7, 2019 11:25
nicolas-grekas added a commit to symfony/symfony that referenced this pull request Apr 7, 2019
@nicolas-grekas
feature #30933 [Routing][ObjectRouteLoader] Allow invokable route loa…
47e571b 
…der services (fancyweb)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Routing][ObjectRouteLoader] Allow invokable route loader services

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | symfony/symfony-docs#11333

#eufossa

Fall back by default on the `__invoke` method when it is not configured.

Using a regex is easier to check that the format is valid, at least for the time we have to supports the single column notation.

TODO :
- [x] Changelog entry
- [x] Doc PR

Commits
-------

5bf7ad4 [Routing][ObjectRouteLoader] Allow invokable route loader services
@OskarStark OskarStark removed the Waiting Code Merge Docs for features pending to be merged label Apr 7, 2019
@wouterj
Copy link
Member
wouterj commented Apr 7, 2019

Thanks for updating the docs for your code contributions, Thomas!

@wouterj wouterj merged commit d9b4121 into symfony:master Apr 7, 2019
wouterj added a commit that referenced this pull request Apr 7, 2019
@wouterj
feature #11333 [Routing] Invokable route loader services (fancyweb)
38e9f40 
This PR was merged into the master branch.

Discussion
----------

[Routing] Invokable route loader services

#eufossa

doc for symfony/symfony#30933

Also the notation with one column has been deprecated so I updated this part as well.

Commits
-------

d9b4121 [Routing] Invokable route loader services
@fancyweb fancyweb deleted the invokable-object-route-loader branch July 10, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming Routing Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fancyweb @wouterj @OskarStark @carsonbot
0