8000 Update default template location for PHP engine by jewome62 · Pull Request #11326 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Update default template location for PHP engine #11326

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update default template location for PHP engine #11326

wants to merge 1 commit into from

Conversation

jewome62
Copy link
@jewome62 jewome62 commented Apr 6, 2019

See into symfony/symfony#30088
The change will be for twig template but not for php.
Currently a deprecated is raised.

EU-FOSSA

@jewome62
Update default template location for PHP engine
678617d 
See into symfony/symfony#30088
The change will be for twig template but not for php.
Currently a deprecated is raised.
@wouterj wouterj added the ⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming label Apr 6, 2019
yceruto
yceruto suggested changes Apr 6, 2019
View reviewed changes
Copy link
Member
@yceruto yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look wrong to me, because the loader of the PHP engine don't look at this templates/ directory. I'll take a look.

@jewome62
Copy link
Author
jewome62 commented Apr 6, 2019

Yes you right, i see it on another issue

@jewome62 jewome62 closed this Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yceruto yceruto yceruto requested changes

Assignees
No one assigned
Labels
⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming Status: Needs Work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jewome62 @yceruto @wouterj @carsonbot
0