E5AD Add documentation for the `require` env processor by mpdude · Pull Request #11313 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Add documentation for the require env processor #11313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2019
Merged

Add documentation for the require env processor #11313

merged 1 commit into from
Apr 7, 2019

Conversation

mpdude
Copy link
Contributor
@mpdude mpdude commented Apr 6, 2019

Documentation for symfony/symfony#30897, discussed on the FOSSHackathon.

@wouterj wouterj added the ⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming label Apr 6, 2019
@javiereguiluz javiereguiluz added the Waiting Code Merge Docs for features pending to be merged label Apr 6, 2019
@wouterj wouterj added this to the next milestone Apr 6, 2019
wouterj
wouterj reviewed Apr 6, 2019
View reviewed changes
Copy link
Member
@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating the documentation directly after submitting the PHP code!!

Once it's merged in the code, we should not forget to add a versionadded directive indicating when this feature was introduced.

OskarStark
OskarStark requested changes Apr 6, 2019
View reviewed changes
Copy link
Contributor
@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a versionadded directive like for the url env car processor

@mpdude mpdude mentioned this pull request Apr 6, 2019
Merged
@mpdude
Copy link
Contributor Author
mpdude commented Apr 6, 2019

@OskarStark latest version added a versionadded notice

symfony-splitter pushed a commit to symfony/dependency-injection that referenced this pull request Apr 7, 2019
@nicolas-grekas
feature #30897 [DIC] Add a require env var processor (mpdude)
bb3a695 
This PR was merged into the 4.3-dev branch.

Discussion
----------

[DIC] Add a `require` env var processor

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        | symfony/symfony-docs#11313

This adds a new `require` processor that will `require()` the PHP file given as input value and return the value `return`ed from that file. Leverages opcaching (yay!).

#EUFOSSA

Commits
-------

03da3a22b1 Add a `require` env var processor
nicolas-grekas added a commit to symfony/symfony that referenced this pull request Apr 7, 2019
@nicolas-grekas
feature #30897 [DIC] Add a require env var processor (mpdude)
c6505d3 
This PR was merged into the 4.3-dev branch.

Discussion
----------

[DIC] Add a `require` env var processor

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        | symfony/symfony-docs#11313

This adds a new `require` processor that will `require()` the PHP file given as input value and return the value `return`ed from that file. Leverages opcaching (yay!).

#EUFOSSA

Commits
-------

03da3a2 Add a `require` env var processor
@OskarStark OskarStark removed the Waiting Code Merge Docs for features pending to be merged label Apr 7, 2019
@wouterj
Copy link
Member
wouterj commented Apr 7, 2019

Thanks again Matthias!

@wouterj wouterj merged commit 1011b42 into symfony:master Apr 7, 2019
wouterj added a commit that referenced this pull request Apr 7, 2019
@wouterj
feature #11313 Add documentation for the require env processor (mpd…
47551a7 
…ude)

This PR was squashed before being merged into the master branch (closes #11313).

Discussion
----------

Add documentation for the `require` env processor

Documentation for symfony/symfony#30897, discussed on the FOSSHackathon.

Commits
-------

1011b42 Add documentation for the `require` env processor
@mpdude mpdude deleted the docs-for-30897 branch April 8, 2019 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj left review comments

@OskarStark OskarStark OskarStark approved these changes

@dbrumann dbrumann dbrumann approved these changes

@maxhelias maxhelias maxhelias approved these changes

Assignees
No one assigned
Labels
⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming Status: Reviewed
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.
7 participants
@mpdude @wouterj @OskarStark @dbrumann @maxhelias @javiereguiluz @carsonbot
0