[Flex] Replace SYMFONY_* env vars with APP_*
#11302
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR was submitted for the 4.1 branch but it was merged into the 4.2 branch instead (closes symfony#10878). Discussion ---------- Minor update Added note to indicate that `$this->isGranted()` only works in a controller, not in an Authenticator. Commits ------- 63f5d66 Minor update
Most of the symfony installation had to install PHP7.2.
The TranslatorInterface has been deprecated in favor of Symfony\Contracts\Translation\TranslatorInterface The Translator::transChoice() method has been deprecated in favor of using Translator::trans() with "%count%" as the parameter driving plurals
This PR was merged into the 4.2 branch. Discussion ---------- Update 4.2 deprecation The TranslatorInterface has been deprecated in favor of Symfony\Contracts\Translation\TranslatorInterface The Translator::transChoice() method has been deprecated in favor of using Translator::trans() with "%count%" as the parameter driving plurals <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- dc1be60 Update 4.2 deprecation
This PR was merged into the 4.2 branch. Discussion ---------- Update web_server_configuration Most of the symfony installation had to install PHP7.2. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- c7ee69b Update web_server_configuration
…iler article (javiereguiluz) This PR was squashed before being merged into the 4.2 branch (closes symfony#10970). Discussion ---------- Merged some profiler docs into a single main Profiler article Instead of an empty Profiler page (https://symfony.com/doc/current/profiler.html) and some links to micro-articles ... this PR proposes to create a reference article about the Profiler and merge most of those micro-articles into it. Commits ------- 2b3384e Merged some profiler docs into a single main Profiler article
* 3.4: Update web_link.rst
* 3.4: changed roles for Nicolas and Christian Update sequence_provider.rst
This PR was merged into the 4.2 branch. Discussion ---------- Fix typo in the profiler article Commits ------- a579c6e Fix typo in the profiler article
* 3.4: added the diversity guidance team
Wrong controller action name.
This PR was merged into the 4.2 branch. Discussion ---------- Use "index" instead of "indexAction" Wrong controller action name. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 68d67a5 Use "index" instead of "indexAction"
…ogin article (javiereguiluz) This PR was merged into the 4.2 branch. Discussion ---------- [Security] Added a missing class import in form login article Commits ------- 3d2ccdf [Security] Added a missing class import in form login article
* 3.4: feat(ui): flash message keys added Added a brief mention about upgrading custom bundle config to Flex
* 3.4: Backported symfony#10998 to 3.4
…aviereguiluz) This PR was squashed before being merged into the 4.2 branch (closes symfony#10995). Discussion ---------- Update some articles related to user providers This makes the security/user_provider.rst a reference article which explains everything about all user providers (except LDAP, which is complicated). This could simplify things because allows developers to read just one article to know all the basics about user providers. If you are worried about the length of this single article ... don't worry ... the 500-line length is misleading because most of it is about `configuration-block`. Commits ------- 0af54d5 Update some articles related to user providers
This PR was merged into the 4.2 branch. Discussion ---------- document deprecation of the scale option see symfony/symfony#28570 Commits ------- 6d10f48 document deprecation of the scale option
…aviereguiluz) This PR was squashed before being merged into the 4.2 branch (closes symfony#10995). Discussion ---------- Update some articles related to user providers This makes the security/user_provider.rst a reference article which explains everything about all user providers (except LDAP, which is complicated). This could simplify things because allows developers to read just one article to know all the basics about user providers. If you are worried about the length of this single article ... don't worry ... the 500-line length is misleading because most of it is about `configuration-block`. Commits ------- eff209c Update some articles related to user providers
* 3.4: Replaces ProtocolClassValidator for the second example clarify some DateTimeType widget options
…ansys) This PR was submitted for the master branch but it was merged into the 4.2 branch instead (closes symfony#11293). Discussion ---------- [Setup] Defer the removal of bundle directory Currently, the bundle directory is still referenced after the step where the removal instruction is placed. Commits ------- a0eabfa [Setup] Defer the removal of bundle directory
This PR was merged into the 4.2 branch. Discussion ---------- Update project directory method override This follows up symfony/recipes#564 (not yet merged), and updates the documentation according to the actual code provided in the recipe. Commits ------- f48dd00 Update project directory method override
* 3.4: Fixed the RST syntax of a serializer article
…guiluz) This PR was merged into the 4.2 branch. Discussion ---------- Simplified some docs about getProjectDir Related to symfony#11286, this simplifies things a bit and removes repeated contents. Commits ------- 4ecda82 Simplified some docs about getProjectDir
…ver (javiereguiluz) This PR was squashed before being merged into the 4.2 branch (closes symfony#11261). Discussion ---------- Documented the use of Docker with the Symfony server This need a detailed review by Docker experts. Thanks! Commits ------- 1fe1034 Documented the use of Docker with the Symfony server
This PR was merged into the 4.2 branch. Discussion ---------- Fix local proxy URI scheme Commits ------- 9b0819c Fix local proxy URI scheme
…d (phansys) This PR was submitted for the master branch but it was merged into the 4.2 branch instead (closes symfony#11299). Discussion ---------- [Flex] Tell that `var/logs/` directory was renamed Ref: symfony/symfony#28810 (comment) Commits ------- 2fcd9bc [Flex] Tell that `var/logs/` directory was renamed
* 3.4: fix filepaths for code examples
This PR was squashed before being merged into the 4.2 branch (closes symfony#11067). Discussion ---------- Update "Ignoring Attributes" The `setIgnoredAttributes()` method has been [deprecated](https://github.com/symfony/serializer/blob/4.2/Normalizer/AbstractNormalizer.php#L181). Commits ------- 579ad57 Update \"Ignoring Attributes\"
OskarStark
approved these changes
Apr 5, 2019
xabbuh
approved these changes
Apr 6, 2019
|
So I completely distroyed this PR while trying to merge it into 3.4. I've taken your commit and created a new PR that I just merged (#11312). Thanks for adding this missing step to the documentation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.