8000 move the namespace before the use statements by OskarStark · Pull Request #11292 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

move the namespace before the use statements #11292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2019
Merged

move the namespace before the use statements #11292

merged 1 commit into from
Apr 4, 2019

Conversation

OskarStark
Copy link
Contributor

No description provided.

@OskarStark OskarStark added this to the 3.4 milestone Apr 3, 2019
gregurco
gregurco approved these changes Apr 3, 2019
View reviewed changes
Copy link
Contributor
@gregurco gregurco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@javiereguiluz
Copy link
Member

Great attention to detail. Thanks.

@javiereguiluz javiereguiluz merged commit c5d217e into symfony:3.4 Apr 4, 2019
javiereguiluz added a commit that referenced this pull request Apr 4, 2019
@javiereguiluz
6f1f6c0 
This PR was merged into the 3.4 branch.

Discussion
----------

move the namespace before the use statements

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

c5d217e move the namespace before the use statements
@OskarStark OskarStark deleted the namespace-before-use-statements branch April 4, 2019 06:49
@OskarStark
Copy link
Contributor Author

Great attention to detail. Thanks.

Thanks, a rule is available from now on 💪 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregurco gregurco gregurco approved these changes

Assignees
No one assigned
Labels
Serializer Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@OskarStark @javiereguiluz @gregurco @carsonbot
0