8000 Document the yaml_file usage by GaryPEGEOT · Pull Request #11121 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Document the yaml_file usage #11121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Document the yaml_file usage #11121

wants to merge 7 commits into from

Conversation

GaryPEGEOT
Copy link
Contributor

@GaryPEGEOT GaryPEGEOT mentioned this pull request Mar 10, 2019
Closed
@HeahDude HeahDude added this to the 4.3 milestone Mar 10, 2019
HeahDude
HeahDude reviewed Mar 10, 2019
View reviewed changes
@HeahDude HeahDude added the Waiting Code Merge Docs for features pending to be merged label Mar 10, 2019
OskarStark
OskarStark reviewed Mar 10, 2019
View reviewed changes
OskarStark
OskarStark requested changes Mar 10, 2019
View reviewed changes
service_container.rst Outdated
<container xmlns="http://symfony.com/schema/dic/services"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://symfony.com/schema/dic/services
http://symfony.com/schema/dic/services/services-1.0.xsd">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use https here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the previous examples use https, sure about that one?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#11122 is on the go, any addition should be secure now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok then, fixed!

@OskarStark
Copy link
Contributor

Can we merge this?

@javiereguiluz
Copy link
Member

We can't merge!! The related code PR hasn't been merged, right? symfony/symfony#30446

@OskarStark
Copy link
Contributor

Sorry I wanted to comment in the code PR 😊

@xabbuh xabbuh removed this from the 4.3 milestone May 9, 2019
@xabbuh xabbuh added this to the next milestone May 9, 2019
@OskarStark
Copy link
Contributor

The code PR was not merged, so let’s close this one. Anyway thank you for working on this 👍🏻

@OskarStark OskarStark closed this May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeahDude HeahDude HeahDude left review comments

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Config Status: Reviewed Waiting Code Merge Docs for features pending to be merged
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.
6 participants
@GaryPEGEOT @OskarStark @javiereguiluz @HeahDude @xabbuh @carsonbot
0