[DependencyInjection] Doc for Allow to choose an index for service locators #11042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
requested changes
Feb 22, 2019
OskarStark
requested changes
Mar 11, 2019
1b98149 to
e607796
Compare
|
Done, thanks @OskarStark |
OskarStark
requested changes
Mar 11, 2019
e607796 to
6ebdddb
Compare
OskarStark
reviewed
Mar 11, 2019
accec35 to
10cfeb0
Compare
|
The code is merged so I removed the label. |
OskarStark
approved these changes
Mar 30, 2019
|
Thanks @OskarStark |
|
I think we are good to go here. Note for the mergers: this must go in |
10cfeb0 to
d63c298
Compare
javiereguiluz
added a commit
that referenced
this pull request
Sep 24, 2019
…or service locators (Anthony MARTIN) This PR was submitted for the master branch but it was merged into the 4.3 branch instead (closes #11042). Discussion ---------- [DependencyInjection] Doc for Allow to choose an index for service locators Here is the doc for the new feature implemented in : [symfony/symfony#30348](symfony/symfony#30348) that follow the feature [symfony/symfony#30257](symfony/symfony#30257) Commits ------- d63c298 [DependencyInjection] Doc for Allow to choose an index for service locator collection
|
It took us some time ... but this is finally merged! @XuruDragon thanks a lot for your contribution. |
No problem, thanks to you to finally merge it ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the doc for the new feature implemented in : symfony/symfony#30348 that follow the feature symfony/symfony#30257