8000 [Validator] Fix `@Valid` regarding property `traverse` by corphi · Pull Request #10868 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Validator] Fix @Valid regarding property traverse #10868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2019
Merged

[Validator] Fix @Valid regarding property traverse #10868

merged 1 commit into from
Mar 7, 2019

Conversation

corphi
Copy link
Contributor
@corphi corphi commented Jan 12, 2019

While researching for symfony/symfony#27090, the constraint reference turned out to be incorrect.

@corphi corphi force-pushed the constraint-valid-traverse branch 2 times, most recently from fa004a4 to 49354b4 Compare January 26, 2019 15:15
@corphi corphi force-pushed the constraint-valid-traverse branch from 49354b4 to 8ed269f Compare February 3, 2019 21:01
@javiereguiluz javiereguiluz added this to the 3.4 milestone Feb 7, 2019
@corphi corphi force-pushed the constraint-valid-traverse branch from 8ed269f to 0836a48 Compare February 11, 2019 20:52
HeahDude
HeahDude reviewed Feb 16, 2019
View reviewed changes
reference/constraints/Valid.rst
set to ``true``.
If this constraint is applied to a ``Traversable``, then all containing values
will be validated if this option is set to ``true``. This option is ignored on
arrays: Arrays are traversed in either case. Keys are not validated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should need a correction if symfony/symfony#29800 is merged, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, @Valid is working correctly. The docs could just use this clarification. The mentioned pull request is only concerned with other constraints not working correctly.

@corphi corphi force-pushed the constraint-valid-traverse branch from 0836a48 to 6343b24 Compare February 19, 2019 22:14
HeahDude
HeahDude approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor
@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@javiereguiluz
Copy link
Member

Thank you @corphi.

@javiereguiluz javiereguiluz merged commit 6343b24 into symfony:3.4 Mar 7, 2019
javiereguiluz added a commit that referenced this pull request Mar 7, 2019
@javiereguiluz
minor #10868 [Validator] Fix @Valid regarding property traverse (…
e68678a 
…corphi)

This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] Fix `@Valid` regarding property `traverse`

While researching for symfony/symfony#27090, the constraint reference turned out to be incorrect.

Commits
-------

6343b24 Describe actual traversal behaviour
@corphi corphi deleted the constraint-valid-traverse branch March 8, 2019 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeahDude HeahDude HeahDude approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Validator
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@corphi @javiereguiluz @HeahDude @carsonbot
0