8000 Fix variable name in code snippet by freiondrej · Pull Request #10777 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Fix variable name in code snippet #10777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix variable name in code snippet #10777

wants to merge 1 commit into from

Conversation

freiondrej
Copy link
Contributor

No description provided.

kunicmarko20
kunicmarko20 approved these changes Dec 12, 2018
View reviewed changes
Copy link
Contributor
@kunicmarko20 kunicmarko20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congrats on your first contribution!

@kunicmarko20
Copy link
Contributor

Just checked and the issue exists also on 3.4

@javiereguiluz javiereguiluz added this to the 3.4 milestone Dec 12, 2018
@javiereguiluz
Copy link
Member

@freiondrej thank you! We merged it in 3.4 and we'll merge in the upper branches automatically later.

javiereguiluz added a commit that referenced this pull request Dec 12, 2018
@javiereguiluz
minor #10777 Fix variable name in code snippet (freiondrej)
72f3470 
This PR was submitted for the 4.2 branch but it was merged into the 3.4 branch instead (closes #10777).

Discussion
----------

Fix variable name in code snippet

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

f21f37d Fix variable name in code snippet
@freiondrej
Copy link
Contributor Author

@javiereguiluz thanks :)

@freiondrej freiondrej closed this Dec 12, 2018
@freiondrej freiondrej reopened this Dec 12, 2018
@javiereguiluz
Copy link
Member

Note: we must close this PR manually because the proprietary tool we use in Symfony to merge PRs doesn't close them when we change the branch while merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunicmarko20 kunicmarko20 kunicmarko20 approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@freiondrej @kunicmarko20 @javiereguiluz @carsonbot
0