typo in sample of code #10766
Merged
typo in sample of code #10766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello While I test webpack encore on a little project in Symfony 3.4, I notice a typo in the documentation. (src instead of href in the link markup). This typo is also present in the documentation of the youngest version of Symfony (4.0, 4.1, 4.2). Do I have to submit a PR for each version ? Thanks for your attention regarding this little bug. Best regard Arnaud
maxhelias
approved these changes
Dec 10, 2018
|
Well spotted! @arnucci thanks for fixing it and congrats on your first Symfony Docs contribution! You did it great submitting it to the 3.4 branch. We'll merge in the upper branches later automatically. |
javiereguiluz
added a commit
that referenced
this pull request
Dec 11, 2018
This PR was merged into the 3.4 branch. Discussion ---------- typo in sample of code Hello While I test webpack encore on a little project in Symfony 3.4, I notice a typo in the documentation. (src instead of href in the link markup). This typo is also present in the documentation of the youngest version of Symfony (4.0, 4.1, 4.2). Do I have to submit a PR for each version ? Thanks for your attention regarding this little bug. Best regard Arnaud <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- cba050a typo in sample of code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
While I test webpack encore on a little project in Symfony 3.4, I notice a typo in the documentation. (src instead of href in the link markup).
This typo is also present in the documentation of the youngest version of Symfony (4.0, 4.1, 4.2).
Do I have to submit a PR for each version ?
Thanks for your attention regarding this little bug.
Best regard
Arnaud