8000 Fixed the TOC of the main Forms article by javiereguiluz · Pull Request #10713 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Fixed the TOC of the main Forms article #10713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fixed the TOC of the main Forms article #10713

wants to merge 2 commits into from

Conversation

javiereguiluz
Copy link
Member

No description provided.

@javiereguiluz javiereguiluz added this to the 3.4 milestone Nov 28, 2018
kunicmarko20
kunicmarko20 reviewed Nov 28, 2018
View reviewed changes
forms.rst
* :doc:`/controller/upload_file`
* :doc:`/reference/forms/types`
* :doc:`/http_cache/form_csrf_caching`
/controller/upload_file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that slash at the beginning needed? since form/* doesn't have it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I've added the leading slash to forms.

Also, it looks like all formats are supported. Most toctree add a leading /, some don't. Most toctree don't add .rst suffix. Some do.

@kunicmarko20
Copy link
Contributor

Looks like there is an issue with plaformsh

@javiereguiluz
Copy link
Member Author

@kunicmarko20 yes, all builds are failing at the moment. We'll contact them. Cheers.

javiereguiluz added a commit that referenced this pull request Nov 28, 2018
minor #10713 Fixed the TOC of the main Forms article (javiereguiluz)
a21e573 
This PR was squashed before being merged into the 3.4 branch (closes #10713).

Discussion
----------

Fixed the TOC of the main Forms article

Commits
-------

4e3c329 Fixed the TOC of the main Forms article
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunicmarko20 kunicmarko20 kunicmarko20 approved these changes

Assignees
No one assigned
Labels
Form Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@javiereguiluz @kunicmarko20 @carsonbot
0