8000 Document changes in the deprecation error handler by greg0ire · Pull Request #10701 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Document changes in the deprecation error handler #10701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom 8000
Closed
wants to merge 1 commit into from
Closed

Document changes in the deprecation error handler #10701

wants to merge 1 commit into from

Conversation

greg0ire
Copy link
Contributor

@greg0ire greg0ire mentioned this pull request Nov 24, 2018
Merged
7 tasks
@javiereguiluz javiereguiluz added the Waiting Code Merge Docs for features pending to be merged label Dec 3, 2018
TimoBakx
TimoBakx approved these changes Dec 8, 2018
View reviewed changes
Copy link
Member
@TimoBakx TimoBakx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clear documentation.

@greg0ire greg0ire mentioned this pull request Dec 29, 2018
Closed
@llaakkkk llaakkkk mentioned this pull request Apr 6, 2019
Closed
@llaakkkk
Copy link
llaakkkk commented Apr 6, 2019

Thank you very much for your pull request!

As part of the Symfony EU funded hackathon (https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming), we were able to assemble most of the core team and big contributors in one place. Our goal is to finish as many open issues and PRs as possible.

Your commits will not be lost and you will therefore get credit for your work. All that will happen is that your commits will be moved to a new PR where all remaining concerns will be addressed.

Without your work this would not have been possible. So thank you once again!

fabpot added a commit to symfony/symfony that referenced this pull request Apr 12, 2019
@fabpot
feature #29211 [PhpUnitBridge] Url encoded deprecations helper config…
a36fbe3 
… (greg0ire)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[PhpUnitBridge] Url encoded deprecations helper config

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #28048
| License       | MIT
| Doc PR        | symfony/symfony-docs#10701

First stab at implementing a new way of configuring the deprecation error handler. Includes a refactoring to keep things manageable.

Rework of #24867, blocked by #29718

TODO:

- [x] make the code 5.5 compatible 😢
- [x] add more tests
- [x] deprecate modes (using echo :P)
- [x] test this on real life projects and add some screenshots
- [x] docs PR
- [x] handle `strict`
- [x] adapt existing CI config

# Quiet configuration

![quiet](https://user-images.githubusercontent.com/657779/49341318-fa78c900-f64b-11e8-9504-a8a9eac4baf8.png)

# Default configuration

![verbose](https://user-images.githubusercontent.com/657779/49341322-10868980-f64c-11e8-9d90-dc3f6a18c335.png)

Commits
-------

1c73f9c [PhpUnitBridge] Url encoded deprecations helper config
@javiereguiluz javiereguiluz removed the Waiting Code Merge Docs for features pending to be merged label Apr 26, 2019
@OskarStark
Copy link
Contributor

This one looks finished and the code is merged

@greg0ire
Copy link
Contributor Author
greg0ire commented Apr 28, 2019 •
edited
Loading

@llaakkkk made a PR that supersedes this one, don't merge!

@OskarStark
Copy link
Contributor

Ok so this one can be closed?

@greg0ire
Copy link
Contributor Author

It will be autoclosed when the other one is merged

@greg0ire greg0ire deleted the url_encoded_config branch May 31, 2019 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimoBakx TimoBakx TimoBakx approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@greg0ire @llaakkkk @OskarStark @TimoBakx @javiereguiluz @carsonbot
0