[Messenger] Multiples buses, scoping handlers per bus, PSR-4 discovery & debug #10689

ogizanagi · 2018-11-20T13:31:34Z

ogizanagi · 2018-11-20T13:34:04Z

messenger/multiple-buses.rst

+                            - validation
+                    messenger.bus.events:
+                        middleware:
+                            - allow_no_handler


Note for 4.2: to be changed in favor of default_middleware: 'allow_no_handers'

(cf https://github.com/symfony/symfony/blob/master/UPGRADE-4.2.md#frameworkbundle)

javiereguiluz

messenger/multiple-buses.rst

ogizanagi · 2018-11-21T12:36:11Z

messenger/multiple_buses.rst

magnusnordlander

ogizanagi · 2018-12-10T12:28:35Z

weaverryan

messenger/multiple_buses.rst

weaverryan · 2018-12-19T21:10:01Z

messenger/multiple_buses.rst

+                bind:
+                    $commandBus: '@messenger.bus.commands'
+                    $queryBus: '@messenger.bus.queries'
+                    $eventBus: '@messenger.bus.events'


Just a note - we'll need another PR in Symfony 4.2, because (I believe) these bindings are done automatically.

Well, it is indeed, but here is what it looks like:

Symfony\Component\Messenger\MessageBusInterface $messengerBusEvents (debug.traced.messenger.bus.events)

as the bus id is messenger.bus.events.
~~Perhaps we should improve this on Symfony FWB's side, removing the messenger.bus prefix, but that's introducing another convention.~~
Or we could update the docs to switch using command_bus, query_bus, event_bus in Messenger config instead of their prefixed counterparts. There are few chances to conflict with other services ids, but the prefixed versions were naturally teaching there is no convention; configured buses ids are actual service ids to use.

Nevertheless, there is a very good point here: in 4.2, we could put forward usages of typed+named aliases instead of bindings (and at least we should add the typehint in bindings).

WDYT ?

messenger/multiple_buses.rst

weaverryan · 2018-12-19T21:13:21Z

messenger/multiple_buses.rst

+This way, the ``App\MessageHandler\SomeCommandHandler`` handler will only be
+known by the ``messenger.bus.commands`` bus.
+
+You can also leverage PSR-4 discovery to configure your handlers automatically:


I don't think people really know this is called PSR-4 discovery. How about:

You can also automatically add this tag to a number of classes by following a naming convention
and registering all of the handler services by name with the correct tag:

Should we officially use it or find a better name for this then?

Note: that's the name used in https://symfony.com/blog/new-in-symfony-3-3-psr-4-based-service-discovery

messenger/multiple_buses.rst

ogizanagi · 2018-12-20T12:30:34Z

javiereguiluz · 2018-12-27T17:00:30Z

@Nyholm

carsonbot added Status: Needs Review Messenger labels Nov 20, 2018

ogizanagi commented Nov 20, 2018

View reviewed changes

ogizanagi force-pushed the messenger/multiple_bus-psr4 branch from 809bf12 to 66b6fda Compare November 20, 2018 13:36

ogizanagi mentioned this pull request Nov 20, 2018

[Messenger][WIP] Show how to configure multiple buses #10016

Closed

javiereguiluz reviewed Nov 20, 2018

View reviewed changes

ogizanagi force-pushed the messenger/multiple_bus-psr4 branch 3 times, most recently from a3071da to cc2cfb4 Compare November 21, 2018 12:35

ogizanagi force-pushed the messenger/multiple_bus-psr4 branch from cc2cfb4 to 77fcfef Compare November 21, 2018 14:43

Added configuration for multiple buses

9973d67

ogizanagi force-pushed the messenger/multiple_bus-psr4 branch 2 times, most recently from cd857f8 to 5ecca74 Compare November 28, 2018 13:49

ogizanagi mentioned this pull request Nov 28, 2018

[Messenger] Added a trait for synchronous query & command buses #10715

Merged

carsonbot removed the Status: Needs Review label Dec 8, 2018

magnusnordlander approved these changes Dec 8, 2018

View reviewed changes

messenger/multiple_buses.rst Outdated Show resolved Hide resolved

messenger/multiple_buses.rst Outdated Show resolved Hide resolved

carsonbot added the Status: Reviewed label Dec 8, 2018

magnusnordlander suggested changes Dec 8, 2018

View reviewed changes

carsonbot added Status: Needs Work and removed Status: Reviewed labels Dec 8, 2018

ogizanagi force-pushed the messenger/multiple_bus-psr4 branch from 5ecca74 to 4c373ac Compare December 10, 2018 12:27

carsonbot added Status: Needs Review and removed Status: Needs Work labels Dec 10, 2018

weaverryan reviewed Dec 19, 2018

View reviewed changes

greg0ire suggested changes Dec 19, 2018

View reviewed changes

messenger/multiple_buses.rst Outdated Show resolved Hide resolved

messenger/multiple_buses.rst Outdated Show resolved Hide resolved

messenger/multiple_buses.rst Show resolved Hide resolved

messenger/multiple_buses.rst Outdated Show resolved Hide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels Dec 19, 2018

[Messenger] Multiples buses, scoping handlers per bus, PSR-4 discover…

4a3f754

…y & debug

ogizanagi force-pushed the messenger/multiple_bus-psr4 branch from 180594b to 4a3f754 Compare December 20, 2018 12:27

carsonbot added Status: Needs Review and removed Status: Needs Work labels Dec 20, 2018

javiereguiluz added Status: Reviewed and removed Status: Needs Review labels Dec 27, 2018

javiereguiluz added this to the 4.1 milestone Dec 27, 2018

javiereguiluz merged commit 4a3f754 into symfony:4.1 Dec 27, 2018

ogizanagi deleted the messenger/multiple_bus-psr4 branch December 27, 2018 17:18

ogizanagi mentioned this pull request Dec 28, 2018

[Messenger] Fix allow_no_handlers for 4.2 #10816

Merged

ogizanagi mentioned this pull request Jan 5, 2019

Describe things more precisely #10845

Closed

xabbuh added a commit that referenced this pull request Mar 9, 2019

[#10689] some minor tweaks

1adbe37

javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Mar 11, 2019

Merge branch '4.2'

ad68339

* 4.2: moved XSD to HTTPS [symfony#10689] some minor tweaks [symfony#10554] fix a minor typo

Uh oh!

[Messenger] Multiples buses, scoping handlers per bus, PSR-4 discovery & debug #10689

[Messenger] Multiples buses, scoping handlers per bus, PSR-4 discovery & debug #10689

Uh oh!

Conversation

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!