Added a note about the usage of NotBlank #10407
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ping-localhost
approved these changes
Sep 26, 2018
reference/constraints/Email.rst
Outdated
| @@ -88,6 +88,14 @@ Basic Usage | |||
| } | |||
| } | |||
|
|
|||
| .. note:: | |||
|
|
|||
| As it happens with the rest of constraints, ``null`` values and empty strings | |||
There was a problem hiding this comment.
How about As with the rest of the constraints?
ping-localhost
approved these changes
Sep 26, 2018
xabbuh
reviewed
Sep 30, 2018
| are considered valid values. Otherwise, in addition to validating this value, | ||
| you would also be requiring it, making it impossible to be optional. That's | ||
| why it's common to combine this constraint with | ||
| :doc:`NotBlank </reference/constraints/NotBlank>`. |
There was a problem hiding this comment.
I thought if we should maybe reword this a bit:
As with most of the other constraints,
nullvalues and empty strings are considered valid values. This is to allow them to be optional values. If the values is mandatory, a common solution is to combine this constraint withNotBlank.
There was a problem hiding this comment.
I think that your wording is better. Could you please create a pull request for it? Thanks a lot!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4244 and fixes #10357.