[Encore] unify the name of app file #10362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
approved these changes
Oct 1, 2018
Member
|
Thank you Vlad! |
weaverryan
added a commit
that referenced
this pull request
Oct 8, 2018
This PR was merged into the 3.4 branch. Discussion ---------- [Encore] unify the name of app file Hello. I found 2 problems related to app file in WebPack config: 1) Relative path was not used in one place (`'assets/js/app.js'` instead of `'./assets/js/app.js'`) - what caused an error in my case. 2) In some cases there was `main.js` instead of `app.js`, but everywhere in text I found references only to `app.js` file. I guess it should be unified. Commits ------- 9c65752 [Encore] unify the name of app file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I found 2 problems related to app file in WebPack config:
'assets/js/app.js'instead of'./assets/js/app.js') - what caused an error in my case.main.jsinstead ofapp.js, but everywhere in text I found references only toapp.jsfile. I guess it should be unified.