8000 [HttpFoundation] Small fixes on some examples by nicoweb · Pull Request #10247 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

[HttpFoundation] Small fixes on some examples #10247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2018

Conversation

nicoweb
Copy link
Contributor
@nicoweb nicoweb commented Sep 3, 2018

There were some small mistakes on "Processing HTTP Headers" section.

There were some small mistakes on "Processing HTTP Headers" section.
Copy link
Member
@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just executed these examples myself and the fixes are totally correct! Thanks a lot @nicoweb!

@javiereguiluz
Copy link
Member

It's merged now! @nicoweb thank you ... and congrats on your first Symfony Docs contribution!

@javiereguiluz javiereguiluz merged commit 804bc7c into symfony:4.1 Sep 3, 2018
javiereguiluz added a commit that referenced this pull request Sep 3, 2018
This PR was merged into the 4.1 branch.

Discussion
----------

[HttpFoundation] Small fixes on some examples

There were some small mistakes on "Processing HTTP Headers" section.

Commits
-------

804bc7c [HttpFoundation] Small fixes on some examples
@nicoweb nicoweb deleted the patch-3 branch September 10, 2018 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0