8000 [Security] Fix wrong exception used in custom authentication provider example by norkunas · Pull Request #10220 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Security] Fix wrong exception used in custom authentication provider example #10220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Security] Fix wrong exception used in custom authentication provider example #10220

wants to merge 1 commit into from

Conversation

norkunas
Copy link
Contributor

Closes #10217

@norkunas norkunas changed the title Fix wrong exception used in custom authentication provider example [Security] Fix wrong exception used in custom authentication provider example Aug 24, 2018
@xabbuh xabbuh added this to the 2.8 milestone Aug 24, 2018
@xabbuh
Copy link
Member
xabbuh commented Aug 24, 2018

I think we could also merge this into the 2.8 branch to show forward compatible code.

@xabbuh xabbuh modified the milestones: 2.8, 4.1 Aug 24, 2018
@xabbuh
Copy link
Member
xabbuh commented Aug 24, 2018

Thank you @norkunas.

xabbuh added a commit that referenced this pull request Aug 24, 2018
@xabbuh
minor #10220 [Security] Fix wrong exception used in custom authentica…
dffddaa 
…tion provider example (norkunas)

This PR was submitted for the 4.0 branch but it was merged into the 4.1 branch instead (closes #10220).

Discussion
----------

[Security] Fix wrong exception used in custom authentication provider example

Closes #10217

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

c36e7f0 Fix wrong exception used in custom authentication provider example
@xabbuh xabbuh closed this Aug 24, 2018
@norkunas norkunas deleted the fix2 branch August 24, 2018 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@norkunas @xabbuh @carsonbot
0