Added a tip about versioning when using Flex #10190
Conversation
Gave it a shot myself, please feel free to edit, closes symfony#10176.
frontend/encore/versioning.rst
Outdated
| .. tip:: | ||
|
|
||
| If your project uses Symfony Flex, a file called ``assets.yaml`` is created upon installation of Webpack Encore containing the lines above, so you don't have to manually add them to ``framework.yaml``. | ||
|
|
There was a problem hiding this comment.
What if we assume the user is using Flex (that's the general policy on the 4.0+ docs). We could:
A) Update the filename in code block above to be assets.yaml
B) Add a comment at the top of the code block:
This file is added automatically when installing Encore with Symfony Flex
Then we can remove this extra tip :). WDYT?
There was a problem hiding this comment.
Yes you are right, that makes more sense! I've applied the changes, I also took a look at comments in other YAML files in the docs and it seems that most of them start with a lowercase letter and no blank lines between them, you think it's okay like this?
This PR was squashed before being merged into the 4.1 branch (closes #10190). Discussion ---------- Added a tip about versioning when using Flex Gave it a shot myself, please feel free to edit, closes #10176. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- f01e6eb Added a tip about versioning when using Flex
|
@royklutman thanks for reporting this issue and for having fixed it yourself! Sorry it took us so long to merge. By the way, GitHub shows this PR as "closed" instead of "merged" (because we squashed it and made some changes) but it's "merged". @xabbuh I've removed the comment you mentioned too. |
Gave it a shot myself, please feel free to edit, closes #10176.