-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
docker-compose autobuild #10131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker-compose autobuild #10131
Conversation
@marfillaster thanks for this contribution! Could you please share the requirements and exact steps one must follow to use this? I guess the requirements is only to download and install Docker community edition from https://www.docker.com/get-docker but then ... which exact commands should I execute to run this? Thanks! |
Added the requirement and how to run |
I'm really interested in adding simple Docker support for this repository. However, I'd like to ask you about the proposal to include "watchman" too. Although is cool that you change some file and docs are built automatically ... I don't think it's that bad to run that command manually yourself. So, could we remove "watchman" in order to simplify things and easy future maintenance? Thanks! |
I removed watchman and docker-compose to simplify. Bonus: project is now compatible |
This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #10131). Discussion ---------- docker-compose autobuild docker-compose - local setup 127.0.0.1:8000 - autobuild using watchman Requirements: - docker-compose 1.10.0+ and latest docker engine How to run: docker-compose up Commits ------- ce491a5 Add Dockerfile
@marfillaster we finally merged this! Sorry it took us so long and thanks for your help! By the way, I created a new pull request to tweak a bit one of the commands you proposed. See #10490. |
This PR was squashed before being merged into the 2.8 branch (closes #10490). Discussion ---------- Updated the command to run the Docker image We merged #10131 but the command shown to serve the image locally doesn't work for me. I'm using Docker 18.06.0-ce. The change I made in this PR worked for me ... but we'd need the help of Docker experts to verify and discuss about the best possible command that will work under any circumstances. Thanks! Commits ------- f277bdf Updated the command to run the Docker image
docker-compose
Requirements:
How to run:
docker-compose up