8000 [Serializer] add a constructor argument to return CSV always as collection · Issue #9383 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Serializer] add a constructor argument to return CSV always as collection #9383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Mar 2, 2018 · 2 comments
Closed

[Serializer] add a constructor argument to return CSV always as collection #9383

javiereguiluz opened this issue Mar 2, 2018 · 2 comments
Labels
hasPR A Pull Request has already been submitted for this issue. Serializer
Milestone
4.1

Comments

@javiereguiluz
Copy link
Member

The PR has a photo, but no detailed description and no examples 😢

symfony/symfony#25218
@javiereguiluz javiereguiluz added this to the 4.1 milestone Mar 2, 2018
@Simperfit
Copy link
Contributor
Simperfit commented Mar 6, 2018 •
edited
Loading

PR done

And btw what you said is wrong, there is a description ;):

This is to be able to add a new behaviour to the csv encoder when passing the alwaysAsCollection context key, this will return a collection even if there is only one element.

@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Mar 7, 2018
@javiereguiluz javiereguiluz changed the title [Serializer] add a constructor arguement to return csv always as collection [Serializer] add a constructor argument to return CSV always as collection Mar 7, 2018
@Simperfit Simperfit mentioned this issue Mar 12, 2018
Merged
javiereguiluz added a commit that referenced this issue Mar 12, 2018
@javiereguiluz
minor #9296 [Serializer] feature: add the context key and add a link …
ada8440 
…to the encoders in serializer to avoid duplication. (Simperfit)

This PR was merged into the master branch.

Discussion
----------

[Serializer] feature: add the context key and add a link to the encoders in serializer to avoid duplication.

Fixes #9384 and #9383.

Commits
-------

e6d3f77 feature: add the context key documentation and remove encoders documentation
@javiereguiluz
Copy link
Member Author

Fixed by #9296.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. Serializer
Projects
None yet
Milestone
4.1
Development

No branches or pull requests
3 participants
@javiereguiluz @xabbuh @Simperfit
0