8000 Document the Workflow deprecations · Issue #9017 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Document the Workflow deprecations #9017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Jan 8, 2018 · 4 comments
Closed

Document the Workflow deprecations #9017

javiereguiluz opened this issue Jan 8, 2018 · 4 comments
Labels
Workflow
Milestone
4.1

Comments

@javiereguiluz
Copy link
Member

symfony/symfony#24751:

  • Deprecated the add method in favor of the addWorkflow method in Workflow\Registry.
  • Deprecated SupportStrategyInterface in favor of WorkflowSupportStrategyInterface.
  • Deprecated the class ClassInstanceSupportStrategy in favor of the class InstanceOfSupportStrategy.

@Simperfit do you think you could update the Workflow examples in the master branch of the docs to update for these deprecations? In addition to updating the example contents, we'd need to add cautions like this:

.. versionadded:: 4.1
    The ``addWorkflow()`` method was introduced in Symfony 4.1. In previous
    Symfony versions it was called ``add()``.

Thanks!
@javiereguiluz javiereguiluz added this to the 4.1 milestone Jan 8, 2018
@Simperfit
Copy link
Contributor
Simperfit commented Jan 11, 2018 •
edited
Loading

Yes, I'm going to do it tomorrow, could you please assign this issue to me ? @javiereguiluz

@javiereguiluz
Copy link
Member Author

@Simperfit thanks! ... and sorry because GitHub doesn't let me assign it to you :(

@Simperfit Simperfit mentioned this issue Jan 12, 2018
Merged
javiereguiluz added a commit that referenced this issue Jan 12, 2018
@javiereguiluz
minor #9039 [Workflow] feature: update the exemple (Simperfit)
6a6f05b 
This PR was merged into the master branch.

Discussion
----------

[Workflow] feature: update the exemple

First fix for #9017 by updating the exemples.

Commits
-------

7161148 feature: update the exemple
@Simperfit
Copy link
Contributor

@javiereguiluz this one can be close I think, there are no usage of SupportStrategyInterface or ClassInstanceSupportStrategy in the docs. but we need to take care of #7439

@javiereguiluz
Copy link
Member Author

You are right. Closing then. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Workflow
Projects
None yet
Milestone
4.1
Development

No branches or pull requests
2 participants
@javiereguiluz @Simperfit
0