8000 [Filesystem] deprecate relative paths in makePathRelative() · Issue #8453 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Filesystem] deprecate relative paths in makePathRelative() #8453

New issue

Have a question about this project? Sign up for a free GitHub account to open 8000 an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Oct 3, 2017 · 0 comments
Closed

[Filesystem] deprecate relative paths in makePathRelative() #8453

javiereguiluz opened this issue Oct 3, 2017 · 0 comments
Labels
Filesystem hasPR A Pull Request has already been submitted for this issue.
Milestone
3.4

Comments

@javiereguiluz
Copy link
Member

See symfony/symfony#24202
@javiereguiluz javiereguiluz added this to the 3.4 milestone Oct 3, 2017
@javiereguiluz javiereguiluz mentioned this issue Oct 4, 2017
Merged
@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Oct 4, 2017
xabbuh added a commit that referenced this issue Oct 13, 2017
@xabbuh
minor #8474 Reworded some explanations about Filesystem methods (javi…
5447036 
…ereguiluz)

This PR was merged into the 2.7 branch.

Discussion
----------

Reworded some explanations about Filesystem methods

I was trying to solve #8453, but I'm not sure we need to add a deprecation notice for that change (because we always explained and assumed that absolute paths are used).

However, I propose to reword some explanations for some methods.

Commits
-------

4eb0c4c Reworded some explanations about Filesystem methods
@xabbuh xabbuh closed this as completed Oct 13, 2017
5023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Filesystem hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
3.4
Development

No branches or pull requests
2 participants
@javiereguiluz @xabbuh
0