8000 Docs for ResetType button are unclear · Issue #6864 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Docs for ResetType button are unclear #6864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mickaelandrieu opened this issue Aug 9, 2016 · 5 comments
Closed

Docs for ResetType button are unclear #6864

mickaelandrieu opened this issue Aug 9, 2016 · 5 comments
Labels
Form hasPR A Pull Request has already been submitted for this issue.

Comments

@mickaelandrieu
Copy link
Contributor

Hi,

if we copy paste the samples produced in this page, we will generate an instance of ButtonType instead of ResetType.

2 possibles solutions:

  • duplicate the templates included (few gains, few pains ?)
  • Maybe add a note like this: "Note theses examples come from ButtonType documentation, and you have to use ResetType::class instead in order to generate a reset button"

What do you think ?

Mickaël
@snoek09
Copy link
snoek09 commented Aug 12, 2016

This issue is there for most code examples in the Type documentation.
To fix this a lot of include files have to be duplicated and changed to match the correct Type.

@mickaelandrieu
Copy link
Contributor Author
mickaelandrieu commented Aug 12, 2016 •
edited
Loading

@snoek09 I'm not in favor of more work for Docs team, this is why I suggest - also - to add a notice :)

@weaverryan
Copy link
Member

Nice catch @mickaelandrieu! Of course the first option is better, but more work. So, let's do the 2nd option.

Btw, internally, we've been talking about adding more intelligence to our build process, so that we could - in theory - include templates, but pass them variables.

@snoek09
Copy link
snoek09 commented Aug 12, 2016

The SubmitType documentation has the same issue.

@xabbuh xabbuh added the Form label Sep 21, 2016
This was referenced Apr 8, 2017
Closed
Closed
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Apr 8, 2017
@javiereguiluz javiereguiluz mentioned this issue Apr 19, 2017
Closed
xabbuh added a commit that referenced this issue Apr 27, 2017
@xabbuh
minor #7824 Fixed the form types of the buttons in the Form reference…
a5ea888 
… (javiereguiluz)

This PR was squashed before being merged into the 2.8 branch (closes #7824).

Discussion
----------

Fixed the form types of the buttons in the Form reference

This fixes #6864.

Commits
-------

7239fb9 Fixed the form types of the buttons in the Form reference
@xabbuh xabbuh closed this as completed Apr 27, 2017
@mickaelandrieu
Copy link
Contributor Author

Thank you @xabbuh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Form hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@snoek09 @weaverryan @mickaelandrieu @xabbuh
0