8000 Delete or improve "How to Simulate Authentication with a Token in a Functional Test" article · Issue #6741 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Delete or improve "How to Simulate Authentication with a Token in a Functional Test" article #6741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wouterj opened this issue Jul 9, 2016 · 3 comments
Closed

Delete or improve "How to Simulate Authentication with a Token in a Functional Test" article #6741

wouterj opened this issue Jul 9, 2016 · 3 comments
Labels
hasPR A Pull Request has already been submitted for this issue. Security

Comments

@wouterj
Copy link
Member
wouterj commented Jul 9, 2016

I propose to delete the "How to Simulate Authentication with a Token in a Functional Test" cookbook article:

  • It's an alternative of "How to Simulate HTTP Authentication in a Functional Test", but it doesn't explain when to use this or the other technique.
  • At the bottom, it says "The technique described in How to Simulate HTTP Authentication in a Functional Test is cleaner and therefore the preferred way." Why should we document something that's not recommended?
  • The technique doesn't look clean at all.
@javiereguiluz
Copy link
Member

I dislike the "Auth with a token" tutorial a lot. However, in complex applications the alternative "Auth in tests" technique doesn't work. I always see the first technique implemented.

In any case, I'd merge both articles and add a brief explanation about when to use each of them.

@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Feb 16, 2017
@javiereguiluz javiereguiluz mentioned this issue Feb 16, 2017
Merged
@javiereguiluz
Copy link
Member

Done in #7507.

xabbuh added a commit that referenced this issue Apr 15, 2017
@xabbuh
minor #7507 Merged and improved the articles about testing + authenti…
2de3dd3 
…cation (javiereguiluz, HeahDude)

This PR was merged into the 2.7 branch.

Discussion
----------

Merged and improved the articles about testing + authentication

This fixes #6741.

Commits
-------

fc8e8c6 Fixed status code test
be5fe37 Improved a test
211da90 Merged and improved the articles about testing + authentication
@javiereguiluz
Copy link
Member

Closing it as fixed by #7507.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. Security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@javiereguiluz @wouterj
0