8000 "images/request-flow.png" references Symfony2 · Issue #6480 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

"images/request-flow.png" references Symfony2 #6480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost opened this issue Apr 16, 2016 · 3 comments
Closed

"images/request-flow.png" references Symfony2 #6480

ghost opened this issue Apr 16, 2016 · 3 comments
Labels
hasPR A Pull Request has already been submitted for this issue.

Comments

@ghost
Copy link
ghost commented Apr 16, 2016

images/request-flow.png has "Symfony2 Kernel" instead of "Symfony3 Kernel".

I'd submit a PR, but I'm not sure how the graphic is generated.
@javiereguiluz
Copy link
Member

Updating these images is very time-consuming ... so we usually don't do it 😢 However, if we update this, we should replace Symfony2 by Symfony to make it future-proof. Thanks!

@ghost
Copy link
Author
ghost commented Apr 16, 2016

If that's the case, I'm happy to fill in the "2" with the background color and submit a PR.

Is that okay with you?

@ghost ghost mentioned this issue Apr 16, 2016
Closed
@javiereguiluz
Copy link
Member

@danielcotton that would be a dirty hack ... so I love it 😁

@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Apr 18, 2016
wouterj added a commit that referenced this issue Apr 18, 2016
@wouterj
minor #6481 Remove reference to Symfony2 in request-flow.png (Daniel …
b2df969 
…Cotton)

This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #6481).

Discussion
----------

Remove reference to Symfony2 in request-flow.png

As per discussion in #6480, update the routing flow graphic to remove the reference to Symfony2.

Commits
-------

ae8a340 Remove reference to Symfony2 in request-flow.png
@xabbuh xabbuh closed this as completed Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@javiereguiluz @xabbuh
0