8000 Re-merge Varnish 4.0 docs after server fix · Issue #4415 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Re-merge Varnish 4.0 docs after server fix #4415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
weaverryan opened this issue Nov 3, 2014 · 16 comments
Closed

Re-merge Varnish 4.0 docs after server fix #4415

weaverryan opened this issue Nov 3, 2014 · 16 comments
Labels
On hold Website

Comments

@weaverryan
Copy link
Member

See #4280.

We're waiting on a fix that'll update the fabpot/sphinx-php submodule. Once we have that, we can re-commit the above PR.

/cc @fabpot @javiereguiluz
@weaverryan weaverryan mentioned this issue Nov 3, 2014
Merged
@fabpot
Copy link
Member
fabpot commented Nov 3, 2014

The module has been updated a while ago but apparently that's not enough.

@weaverryan
Copy link
Member Author

@fabpot Hmm, I took a screenshot of the failure when it all happened, just in case it was helpful: #4280 (comment). It is the varnish4 thing, that's about all I know.

@wouterj
Copy link
Member
wouterj commented Nov 3, 2014

Looks like there is an issue with the extension itself...

@xabbuh
Copy link
Member
xabbuh commented Nov 3, 2014

@wouterj I don't think so. Line 51 cannot cause this error message in the current version.

@wouterj
Copy link
Member
wouterj commented Nov 3, 2014

I think some things were missed.

@fabpot/@javiereguiluz could you please check if you updated the conf.py file the same way as #4287 did? I think something was missed because of this comment by @javiereguiluz : #4280 (comment)

Basically, the problem would be that there is no lexer set for the varnish* formats. That's why sphinx is failing to build the page

@fabpot
Copy link
Member
fabpot commented Nov 3, 2014

ahah, of course not. doing that now.

@fabpot
Copy link
Member
fabpot commented Nov 3, 2014

Deployed now. Can we check again?

@weaverryan
Copy link
Member Author

I'll re-add the commits now!

weaverryan added a commit that referenced this issue Nov 3, 2014
@weaverryan
Revert ""Revert "Added config example for Varnish 4.0""""
490ca6b 
This reverts a revert, so really it re-adds #4280. See #4415 also.

This reverts commit b3d96b8.
@weaverryan
Copy link
Member Author

Commits re-added to all branches at sha: 490ca6b

Assuming this works, thanks to everyone for tracking the issue down.
8000

@xabbuh
Copy link
Member
xabbuh commented Nov 3, 2014

Shouldn't the config already have been updated with #4287 being merged?

@weaverryan
Copy link
Member Author

@xabbuh I think the actual build system may use a different file. The build system pre-dates us having that conf.py file in the repo, iirc. I think we added it to help others (and Travis) build the repo.

@wouterj
Copy link
Member
wouterj commented Nov 3, 2014

Yes, all meta files for Sphinx in this repository are purely for local and travis testing. The build process used by symfony.com uses different files, as it also needs to set-up the other documentations and use the correct theme, etc.

@xabbuh
Copy link
Member
xabbuh commented Nov 3, 2014

Hm, maybe we should make this more flexible to ease the build process. Something like allowing to override the configuration locally without the need to redefine everything completely.

@xabbuh
Copy link
Member
xabbuh commented Nov 4, 2014

The Varnish tabs are online! Thanks @fabpot 👍

@xabbuh xabbuh closed this as completed Nov 4, 2014
@javiereguiluz
Copy link
Member

@xabbuh this is great! My only concern is that the syntax highlighting for these blocks of code is weird, specially for comments.

@wouterj
Copy link
Member
wouterj commented Nov 4, 2014

Yeah, they are now set to ruby syntax. The comments are not valid ruby comments. Maybe setting it to C is better in the end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
On hold Website
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fabpot @javiereguiluz @weaverryan @wouterj @xabbuh
0