8000 [Best Practice] Possible form rendering change · Issue #4402 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Best Practice] Possible form rendering change #4402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
weaverryan opened this issue Oct 31, 2014 · 5 comments
Closed

[Best Practice] Possible form rendering change #4402

weaverryan opened this issue Oct 31, 2014 · 5 comments
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.
Milestone
2.6

Comments

@weaverryan
Copy link
Member

Hi guys!

See symfony/symfony#12333 (comment).

Basically, I think we should consider updating the best practice to use form_start and form_end. While I think rendering <form manually is "simpler" in some ways, it's also error-prone (getting out of sync with the method you setup in your form, forgetting the enctype).

What do others think?
@weaverryan weaverryan mentioned this issue Oct 31, 2014
Closed
@masterkaos
Copy link
Contributor

+1. I think the pros outlined in the linked comment far outway the cons.
And like webmozart said, the syntax to add simple things is ugly and should be improved regardless of which option ends up being better. If it is improved, there goes one of the most significant cons.

@wouterj wouterj added actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) Best Practices labels Oct 31, 2014
@wouterj
Copy link
Member
wouterj commented Oct 31, 2014

👍

1 similar comment
@mayeco
Copy link
Contributor
mayeco commented Oct 31, 2014

👍

@webmozart
Copy link
Contributor

👍, obviously :)

@javiereguiluz
Copy link
Member

@weaverryan before making any decision, please keep in mind that your proposed DX improvements for this feature are going to be rejected. Moreover, any improvement related to this will be postponed until 3.0.

@weaverryan weaverryan added this to the 2.6 milestone Nov 5, 2014
@weaverryan weaverryan mentioned this issue Nov 14, 2014
Closed
@wouterj wouterj added the hasPR A Pull Request has already been submitted for this issue. label Nov 18, 2014
weaverryan added a commit that referenced this issue Nov 20, 2014
@weaverryan
feature #4465 Modifying the best practice to use form_start() instead…
422e0f1 
… of <form (weaverryan, WouterJ)

This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #4465).

Discussion
----------

Modifying the best practice to use form_start() instead of <form

| Q   | A
| --- | ---
| Doc fix? | no
| New docs? | no
| Applies to | 2.3+
| Fixed tickets | #4402

Hi guys!

See #4402. This proposes recommending to use `form_start` for the reasons there. There are pros and cons, but after nice chat, I think the pros outweigh the cons.

/cc @webmozart

Thanks!

Commits
-------

ae3b3cd Fixed typo
f1708f5 Modifying the best practice to use form_start() instead of <form
@wouterj wouterj closed this as completed Nov 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
2.6
Development

No branches or pull requests
6 participants
@javiereguiluz @weaverryan @webmozart @mayeco @wouterj @masterkaos
0