10000 [Routing] Documented the option to exclude patterns (Part 2) · Issue #14507 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Routing] Documented the option to exclude patterns (Part 2) #14507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ThomasLandauer opened this issue Nov 1, 2020 · 4 comments
Closed

[Routing] Documented the option to exclude patterns (Part 2) #14507

ThomasLandauer opened this issue Nov 1, 2020 · 4 comments
Labels
hasPR A Pull Request has already been submitted for this issue. Keep open Routing

Comments

@ThomasLandauer
Copy link
Contributor

#12821 leaves many questions open (code box at https://symfony.com/doc/4.4/routing.html#route-groups-and-prefixes)

  • The PHP config doesn't show an example. Since Symfony is moving away from YAML towards PHP, there should be one. What's the starting point of the path - why does the first argument start with ../../, but this one with ../? After half an hour of trial and error, I couldn't get it to work ;-)
  • What's the meaning of the curly braces in the pattern?
  • When the text reads "use the optional fifth argument..." (changed to "fourth" in Update routing.rst #14506), there should be a hint on what to pass as third argument.
@xabbuh xabbuh added the Routing label Nov 2, 2020
@carsonbot
Copy link
Collaborator

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

@carsonbot
Copy link
Collaborator

Could I get a reply or should I close this?

@javiereguiluz
Copy link
Member

Don't close it, please.

@carsonbot carsonbot removed the Stalled label Nov 17, 2021
@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Sep 18, 2023
@javiereguiluz javiereguiluz mentioned this issue Sep 18, 2023
Merged
javiereguiluz added a commit that referenced this issue Sep 19, 2023
@javiereguiluz
minor #18877 [Routing] Improve the explanation of the exclude paramet…
7642001 
…er (javiereguiluz)

This PR was squashed before being merged into the 5.4 branch.

Discussion
----------

[Routing] Improve the explanation of the exclude parameter

Fixes #14507.

Commits
-------

fe04b38 [Routing] Improve the explanation of the exclude parameter
@javiereguiluz
Copy link
Member

Closing as fixed in #18877.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. Keep open Routing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@javiereguiluz @ThomasLandauer @xabbuh @carsonbot
0