8000 [Security] anonymous: lazy deprecation warning · Issue #13749 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content
8000

[Security] anonymous: lazy deprecation warning #13749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rcapile opened this issue Jun 3, 2020 · 4 comments · Fixed by #13750
Closed

[Security] anonymous: lazy deprecation warning #13749

rcapile opened this issue Jun 3, 2020 · 4 comments · Fixed by #13750
Labels
hasPR A Pull Request has already been submitted for this issue. Security

Comments

@rcapile
Copy link
Contributor
rcapile commented Jun 3, 2020

I upgrade to symfony/security-bundle to 5.1 and I got the deprecation warning Since symfony/security-bundle 5.1: Using "anonymous: lazy" to make the firewall lazy is deprecated, use "anonymous: true" and "lazy: true" instead.

But there's nothing about this change in https://symfony.com/doc/current/security.html#a-authentication-firewalls

Sorry I can't make a PR because I believe it would require some explanation why it's now two options and a "New in Version 5.1" box, right?
@yceruto
Copy link
Member
yceruto commented Jun 3, 2020

The doc needs to be update yes, but the recipe was already updated symfony/recipes#778, so you can fix this warning by executing composer sync-recipes --force

@wouterj
Copy link
Member
wouterj commented Jun 3, 2020

Oh sorry for making the change and completely ignoring updating docs and recipes. Thanks @yceruto and @rcapile for taking care of that!

Sorry I can't make a PR because I believe it would require some explanation why it's now two options and a "New in Version 5.1" box, right?

Please feel free to submit a PR. I don't think we need to explain anything here, a "new in 5.1" is usefull though. You can add it using this syntax:

.. versionadded:: 5.1

    The ``lazy: true`` option was introduced in Symfony 5.1. Prior to version 5.1,
    it was enabled using ``anonymous: lazy``

@rcapile rcapile mentioned this issue Jun 3, 2020
Merged
@rcapile
Copy link
Contributor Author
rcapile commented Jun 3, 2020

done

@xabbuh xabbuh added Security hasPR A Pull Request has already been submitted for this issue. labels Jun 4, 2020
@xabbuh xabbuh linked a pull request Jun 4, 2020 that will close this issue
[Security] anonymous: lazy deprecation warning #13750
Merged
javiereguiluz added a commit that referenced this issue Jun 5, 2020
@javiereguiluz
minor #13750 [Security] anonymous: lazy deprecation warning (rcapile)
cf65ee7 
This PR was squashed before being merged into the 5.1 branch.

Discussion
----------

[Security] anonymous: lazy deprecation warning

After upgrade to symfony/security-bundle to 5.1 and I got the deprecation warning Since symfony/security-bundle 5.1: Using "anonymous: lazy" to make the firewall lazy is deprecated, use "anonymous: true" and "lazy: true" instead.
#13749

Commits
-------

73d1789 [Security] anonymous: lazy deprecation warning
@javiereguiluz
Copy link
Member

Fixed in #13750. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. Security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Security] anonymous: lazy deprecation warning rcapile/symfony-docs
5 participants
@javiereguiluz @rcapile @wouterj @xabbuh @yceruto
0