8000 [Messenger] Confusing variable in a code example · Issue #13148 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Messenger] Confusing variable in a code example #13148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Feb 16, 2020 · 0 comments · Fixed by #13349
Closed

[Messenger] Confusing variable in a code example #13148

javiereguiluz opened this issue Feb 16, 2020 · 0 comments · Fixed by #13349
Labels
Messenger

Comments

@javiereguiluz
Copy link
Member

As reported on Symfony Slack by a user called Björn:

Hi, in the documentation for Messenger component, there is a $handler in this snippet which doesn't explain what should represent it
https://symfony.com/doc/current/components/messenger.html#bus
jpjoao added a commit to jpjoao/symfony-docs that referenced this issue Mar 15, 2020
@jpjoao
Make it more obvious what the $handler is (refers to the next item in…
a89e32e 
… the docs)

closes symfony#13148
@jpjoao jpjoao mentioned this issue Mar 15, 2020
Merged
javiereguiluz added a commit that referenced this issue Mar 17, 2020
@javiereguiluz
minor #13349 Make it more obvious what the $handler is on Messenger d…
2309998 
…ocs (jpjoao)

This PR was submitted for the master branch but it was merged into the 4.4 branch instead (closes #13349).

Discussion
----------

Make it more obvious what the $handler is on Messenger docs

fixes #13148

As mentioned in the issue `$handler` was not obvious. I referenced the next item in the docs in the hope that this makes things more clear.

This issue is present on other versions of the documentation but the behaviour of the function also changed (parameter now can be an array). I am unsure of how to proceed in such a case.

Commits
-------

41d017a Make it more obvious what the $handler is (refers to the next item in the docs)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Messenger
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make it more obvious what the $handler is on Messenger docs jpjoao/symfony-docs
1 participant
@javiereguiluz
0