8000 "Routes with optional parameters at the end will not match on requests with a trailing slash" isn't true · Issue #12444 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

"Routes with optional parameters at the end will not match on requests with a trailing slash" isn't true #12444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
8000
Ahmed-Ayman opened this issue Oct 7, 2019 · 1 comment
Closed

"Routes with optional parameters at the end will not match on requests with a trailing slash" isn't true #12444

Ahmed-Ayman opened this issue Oct 7, 2019 · 1 comment
Labels
Routing

Comments

@Ahmed-Ayman
Copy link

here

a note is saying Routes with optional parameters at the end will not match on requests with a trailing slash (i.e. /blog/ will not match, /blog will match).

now I have created an optional @Route("/blog/{page<\d+>}") and tried /blog/ on chrome and it matched the route that I have already set to a default int $page = 0
@thbil
Copy link
Contributor
thbil commented Oct 14, 2019

Hi,
It seems you are correct !
According to symfony/symfony#26283 this note is no longer relevant since v4.1.0-BETA1.
I'll edit the doc this afternoon (at least I'll try to do my first PR).

Cheers.

thbil added a commit to thbil/symfony-docs that referenced this issue Oct 14, 2019
@thbil
Fix issue symfony#12444 (removing irrelevant note)
27fc2ea
@thbil thbil mentioned this issue Oct 14, 2019
Merged
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this issue Oct 15, 2019
@javiereguiluz
Merge branch '4.3' into 4.4
5cb38b9 
* 4.3:
  Fix issue <
6942
a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="503648509" data-permission-text="Title is private" data-url="https://github.com/symfony/symfony-docs/issues/12444" data-hovercard-type="issue" data-hovercard-url="/symfony/symfony-docs/issues/12444/hovercard" href="https://github.com/symfony/symfony-docs/issues/12444">symfony#12444 (removing irrelevant note)
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this issue Oct 15, 2019
@javiereguiluz
Merge branch '4.4'
37917fc 
* 4.4:
  Fix issue symfony#12444 (removing irrelevant note)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Routing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@javiereguiluz @thbil @Ahmed-Ayman
0