8000 [Validator] Missing code example in the IdenticalTo constraint · Issue #10829 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Validator] Missing code example in the IdenticalTo constraint #10829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xElysioN opened this issue Jan 2, 2019 · 1 comment
Closed

[Validator] Missing code example in the IdenticalTo constraint #10829

xElysioN opened this issue Jan 2, 2019 · 1 comment
Labels
hasPR A Pull Request has already been submitted for this issue. Validator
Milestone
3.4

Comments

@xElysioN
Copy link
Contributor
xElysioN commented Jan 2, 2019

Hi,
In the IdenticalTo constraint, there is missing codes in YAML, XML and PHP for the firstname constraint in the Basic Usage, but ok for annotations.

CF : https://symfony.com/doc/3.4/reference/constraints/IdenticalTo.html#basic-usage
xElysioN added a commit to xElysioN/symfony-docs that referenced this issue Jan 2, 2019
@xElysioN
fix symfony#10829: add missing examples in IdenticalTo constraint
14b1acc
@xElysioN xElysioN mentioned this issue Jan 2, 2019
Merged
xElysioN added a commit to xElysioN/symfony-docs that referenced this issue Jan 2, 2019
@xElysioN
fix symfony#10829: add missing examples in IdenticalTo constraint
ad78e1b
@HeahDude HeahDude added Validator hasPR A Pull Request has already been submitted for this issue. labels Jan 3, 2019
@HeahDude HeahDude added this to the 3.4 milestone Jan 3, 2019
javiereguiluz added a commit that referenced this issue Jan 3, 2019
@javiereguiluz
minor #10830 [Validator] Added missing examples in IdenticalTo constr…
c166715 
…aint (xElysioN)

This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] Added missing examples in IdenticalTo constraint

Hi,
This fix #10829 (Missing YAML, XML and PHP example in Basic Usage)

And add missing space for ``age`` in Basic Usage.

Link of changes : https://pr-10830-trovf4q-nq3xa5jtywvyc.eu.s5y.io/reference/constraints/IdenticalTo.html

Commits
-------

ad78e1b fix #10829: add missing examples in IdenticalTo constraint
@javiereguiluz
Copy link
Member

Fixed by #10830.

nikophil pushed a commit to nikophil/symfony-docs that referenced this issue Jan 3, 2019
@xElysioN @nikophil
fix symfony#10829: add missing examples in IdenticalTo constraint
acbca93
nikophil pushed a commit to nikophil/symfony-docs that referenced this issue Jan 3, 2019
@javiereguiluz @nikophil
minor symfony#10830 [Validator] Added missing examples in IdenticalTo…
3434079 
… constraint (xElysioN)

This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] Added missing examples in IdenticalTo constraint

Hi,
This fix symfony#10829 (Missing YAML, XML and PHP example in Basic Usage)

And add missing space for ``age`` in Basic Usage.

Link of changes : https://pr-10830-trovf4q-nq3xa5jtywvyc.eu.s5y.io/reference/constraints/IdenticalTo.html

Commits
-------

ad78e1b fix symfony#10829: add missing examples in IdenticalTo constraint
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this issue Jan 4, 2019
@javiereguiluz
Merge branch '3.4' into 4.1
51ba43b 
* 3.4:
  Update pdo_session_storage.rts
  Missing > in image tags
  fix symfony#10829: add missing examples in IdenticalTo constraint
  Update encore/copy-files.rst: add note about using versioning with custom target path
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this issue Jan 4, 2019
@javiereguiluz
Merge branch '4.1' into 4.2
382f17d 
* 4.1:
  Update pdo_session_storage.rts
  Missing > in image tags
  fix symfony#10829: add missing examples in IdenticalTo constraint
  Update encore/copy-files.rst: add note about using versioning with custom target path
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this issue Jan 4, 2019
@javiereguiluz
Merge branch '4.2'
ac266f0 
* 4.2:
  Update pdo_session_storage.rts
  Missing > in image tags
  fix symfony#10829: add missing examples in IdenticalTo constraint
  Update encore/copy-files.rst: add note about using versioning with custom target path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. Validator
Projects
None yet
Milestone
3.4
Development

No branches or pull requests
3 participants
@javiereguiluz @xElysioN @HeahDude
0