do not try to load translation files from hidden folders #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is indeed a problem i already noticed in another place, maybe we should ignore that folder inside Finder componant itself, personally i added ".AppleDouble" in ignoreVcs method but it's not really a vcs folder, any feedback ? |
|
I'd extend it to dot-folders in general.. unless explicitely stated they are meant to be hidden, hence we can extend that list endlessly |
| @@ -436,7 +436,7 @@ class FrameworkExtension extends Extension | |||
| // Register translation resources | |||
| if ($dirs) { | |||
| $finder = new Finder(); | |||
| $finder->files()->filter(function (\SplFileInfo $file) { return 2 === substr_count($file->getBasename(), '.'); })->in($dirs); | |||
| $finder->files()->filter(function (\SplFileInfo $file) { return (FALSE === strpos($file->getRealPath(), DIRECTORY_SEPARATOR . '.') && 2 === substr_count($file->getBasename(), '.')); })->in($dirs); | |||
There was a problem hiding this comment.
FALSE should be in lowercase
|
thanks @fabpot ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
translation files in hidden folders and hidden translation files should not be loaded.
Eg:
src/Acme/DemoBundle/Resources/translation/.AppleDouble/messages.de.yml