[Intl] Added round support for ROUND_CEILING, ROUND_FLOOR, ROUND_DOWN, ROUND_UP #9895
Conversation
| $roundingModeAttribute = $this->getAttribute(self::ROUNDING_MODE); | ||
| if (isset(self::$phpRoundingMap[$roundingModeAttribute])) { | ||
| $roundingMode = self::$phpRoundingMap[$this->getAttribute(self::ROUNDING_MODE)]; | ||
| $value = round($value, $precision, $roundingMode); |
There was a problem hiding this comment.
Those 2 lines can be replaced with $value = round($value, $precision, self::$phpRoundingMap[$roundingModeAttribute]);
|
Looks good to me, can you add some unit tests? |
| 'ROUND_CEILING' => self::ROUND_CEILING, | ||
| 'ROUND_FLOOR' => self::ROUND_FLOOR, | ||
| 'ROUND_DOWN' => self::ROUND_DOWN, | ||
| 'ROUND_UP' => self::ROUND_UP |
There was a problem hiding this comment.
Please add the trailing comma so that we don't have unneeded diffs on this line when we need to add another one after that
|
I'm wondering if we could extract |
|
I prefer duplicate code in this case |
…ROUND_DOWN, ROUND_UP (pamil) This PR was squashed before being merged into the 2.4 branch (closes #9895). Discussion ---------- [Intl] Added round support for ROUND_CEILING, ROUND_FLOOR, ROUND_DOWN, ROUND_UP | Q | A | ------------- | --- | Bug fix? | yes | New feature? | yes | BC breaks? | no, actually it fixes some | Deprecations? | no | Tests pass? | yes | Fixed tickets | #9838 | License | MIT | Doc PR | Adds support for 4 unsupported rounding modes (ROUND_CEILING, ROUND_FLOOR, ROUND_DOWN, ROUND_UP) in `NumberFormatter` from `Intl` component, so that `Symfony\Component\Form\Extension\Core\DataTransformer\IntegerToLocalizedStringTransformer` won't throw exception if `lib-intl` is not installed. Commits ------- f5fee9a [Intl] Added round support for ROUND_CEILING, ROUND_FLOOR, ROUND_DOWN, ROUND_UP
Adds support for 4 unsupported rounding modes (ROUND_CEILING, ROUND_FLOOR, ROUND_DOWN, ROUND_UP) in
NumberFormatterfromIntlcomponent, so thatSymfony\Component\Form\Extension\Core\DataTransformer\IntegerToLocalizedStringTransformerwon't throw exception iflib-intlis not installed.