8000 [Dependencyinjection] Fixed handling of inlined references in the AnalyzeServiceReferencesPass by fabpot · Pull Request #9885 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Dependencyinjection] Fixed handling of inlined references in the AnalyzeServiceReferencesPass #9885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2013

Conversation

fabpot
Copy link
Member
@fabpot fabpot commented Dec 29, 2013
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #8299, #9829
License MIT
Doc PR n/a

Hopefully a better fix for #9829 (ping @jakzal). Unit tests coming soon.

In some cases InlineServiceDefinitionsPass replaces a Reference with a service Definition. In such scenarios AnalyzeServiceReferencesPass was falling into an infinite loop.

@jakzal
Copy link
Contributor
jakzal commented Dec 29, 2013

I confirm this solves the issue and is a better place to make the fix ;)

…e a service if it's part of the current definition (to avoid an infinite loop)
fabpot added a commit that referenced this pull request Dec 29, 2013
…in the AnalyzeServiceReferencesPass (fabpot)

This PR was merged into the 2.3 branch.

Discussion
----------

[Dependencyinjection] Fixed handling of inlined references in the AnalyzeServiceReferencesPass

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #8299, #9829
| License       | MIT
| Doc PR        | n/a

Hopefully a better fix for #9829 (ping @jakzal). Unit tests coming soon.

In some cases `InlineServiceDefinitionsPass` replaces a Reference with a service Definition. In such scenarios `AnalyzeServiceReferencesPass` was falling into an infinite loop.

Commits
-------

d650295 [DependencyInjection] fixed InlineServiceDefinitionsPass to not inline a service if it's part of the current definition (to avoid an infinite loop)
@fabpot fabpot merged commit d650295 into symfony:2.3 Dec 29, 2013
@fabpot fabpot deleted the analyze-inlined-service-refs branch December 29, 2013 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0