[Yaml][Bug] Fix #9105 - Remove white spaces from yml parameter with html #9787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like it does not follow the standard described in the spec: http://www.yaml.org/spec/1.2/spec.html#id2796251 |
|
I agree with @fabpot. When following the spec, parsing the following Yaml (taken from your new test) test: >
<h2>A heading</h2>
<ul>
<li>a list</li>
<li>may be a good example</li>
</ul>should produce the following code: array ('test' => <<<EOT
<h2>A heading</h2>
<ul>
<li>a list</li>
<li>may be a good example</li>
</ul>
EOT
) |
|
@stof so still there is a bug in the code because it generates one line with a lot of white spaces. I'll try to change behaviour and push a new pull request with proper code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was reported a problem with yaml parser and line breaks in folded style blocks. I have confirmed it and also repaired by adding new regexp to parsing method.