Added tests for #8930 #9764
Added tests for #8930 #9764
Conversation
|
please @thunderer use the template http://symfony.com/doc/current/contributing/code/patches.html#make-a-pull-request |
| array('[@name]', 'Thunderer', array('@name' => 'Thunderer')), | ||
| array('@name', 'Thunderer', (object) array('@name' => 'Thunderer')), | ||
| array('_name', 'Thunderer', (object) array('_name' => 'Thunderer')), | ||
| ); |
|
Are you saying the the bug described in #8930 does not exit? Because I've just tried the script from this issue and indeed, there is an exception. |
|
@fabpot i think he needs to close this since he has done a similar PR but for master. @thunderer only one PR is needed, @fabpot can backtrace it. So please close this one, or the other. Usually is the case that we do bug fixes on the branch where the problem is reported and then @fabpot port this forward. Other projects like doctrine work differently where things are only fixed in the master and they are backtraced. Symfony however does things differently. |
|
@cordoval Thanks for understanding what I've done, I simply didn't know how you handle such situation. @fabpot Yes, I've tested that on my local machine (Ubuntu 12.04, PHP 5.4) and both sample script and tests passed without notice. I'll give it another chance on my main PC (same OS, PHP 5.5) and report changes. I'm curious - if Travis build didn't report anything is something wrong with my approach, test suite or something else? |
|
The issue only appears when using a dot |
|
Closing in favor of #9843 |
These tests are for #8930 - I've refactored tests so that similar ones use @dataProvider annotation. From my experience with the subject this issue happens neither in 2.3 nor in master.