8000 [DoctrineBridge] Fix for cache-key conflict when having a \Traversable as choices by DRvanR · Pull Request #9557 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DoctrineBridge] Fix for cache-key conflict when having a \Traversable as choices #9557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[DoctrineBridge] Fix for cache-key conflict when having a \Traversable as choices #9557

wants to merge 1 commit into from

Conversation

DRvanR
Copy link
@DRvanR DRvanR commented Nov 21, 2013
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #9556
License MIT
Doc PR ~

@fabpot
Copy link
Member
fabpot commented Nov 22, 2013

ping @beberlei @bschussek

@DRvanR
Copy link
Author
DRvanR commented Dec 4, 2013

Is there anything I can do to help get this merged?

@fabpot
Copy link
Member
fabpot commented Dec 4, 2013

@DRvanR convince @beberlei to have a look at the change ;)

@beberlei
Copy link
Contributor
beberlei commented Dec 4, 2013

@DRvanR Can you refactor this to remove the array_walk in is_array and have both if conditions use the same looping mechanism? Otherwise this looks ok. I don't know if there are any tests for this though and we can rely on this working without you adding a new test. I would prefer a test

@DRvanR
Copy link
Author
DRvanR commented Dec 4, 2013

@beberlei will do, will try to have something by the end of the week (swamped with work atm). Do note however that it is array_walk_recursive, with explicitly commented support for recursive arrays. Seems that removing that might be a potential BC break?

@beberlei
Copy link
Contributor
beberlei commented Dec 4, 2013

@DRvanR oh yes you are right, i didnt notice that. Good question then...

fabpot added a commit that referenced this pull request Dec 29, 2013
@fabpot
bug #9557 [DoctrineBridge] Fix for cache-key conflict when having a \…
be01e34 
…Traversable as choices (DRvanR)

This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes #9557).

Discussion
----------

[DoctrineBridge] Fix for cache-key conflict when having a \Traversable as choices

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #9556
| License       | MIT
| Doc PR        | ~

Commits
-------

1119684 Fix for cache-key conflict when having a \Traversable as choices
@fabpot fabpot closed this Dec 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Doctrine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DRvanR @fabpot @beberlei
0