[FrameworkBundle] Fixed the registration of validation.xml file when the form is disabled #9443
Conversation
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
|
What do you mean by "when form is disabled"? |
|
@fabpot in case you don't use forms in your project and are using the subtree splits (thus being able to drop the Form component entirely). FrameworkBundle does not require enabling forms |
|
…the form is disabled
| $container->addResource(new FileResource($files[0])); | ||
| $files = array(); | ||
|
|
||
| if (interface_exists('Symfony\Component\Form\FormInterface')) { |
There was a problem hiding this comment.
what if the classes do exist but there is not will for the validation to be plugged in.
There was a problem hiding this comment.
You're right, it's an imperfect solution, but it is consistent with other solutions - https://github.com/symfony/symfony/blob/2.2/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php#L539
|
The use case of this problem: composer.json: {
"require": {
"symfony/framework-bundle": "2.*",
"symfony/validator": "2.*",
"symfony/yml": "2.*"
}
}config.yml: framework:
validator:
enabled: true
|
…file when the form is disabled (hason) This PR was submitted for the 2.1 branch but it was merged into the 2.2 branch instead (closes #9443). Discussion ---------- [FrameworkBundle] Fixed the registration of validation.xml file when the form is disabled | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- cfa5aa5 [FrameworkBundle] Fixed the registration of validation.xml file when the form is disabled