8000 [2.3] Removed deprecated calls by wouterj · Pull Request #9353 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[2.3] Removed deprecated calls #9353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2013
Merged

[2.3] Removed deprecated calls #9353

merged 1 commit into from
Dec 28, 2013

Conversation

wouterj
Copy link
Member
@wouterj wouterj commented Oct 20, 2013
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

stof
stof reviewed Oct 21, 2013
View reviewed changes
src/Symfony/Bundle/TwigBundle/Controller/ExceptionController.php
@@ -12,7 +12,7 @@
namespace Symfony\Bundle\TwigBundle\Controller;

use Symfony\Bundle\FrameworkBundle\Templating\TemplateReference;
use Symfony\Component\HttpKernel\Exception\FlattenException;
use Symfony\Component\Debug\Exception\FlattenException;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a BC break for people extending the controller (it changes the signature), which is why a previous PR changing it has already been reverted

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@wouterj
Copy link
Member Author
wouterj commented Dec 28, 2013

OK, reverted namespace changes.

fabpot added a commit that referenced this pull request Dec 28, 2013
@fabpot
minor #9353 [2.3] Removed deprecated calls (WouterJ)
fac711c 
This PR was merged into the 2.3 branch.

Discussion
----------

[2.3] Removed deprecated calls

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

a6562b3 Fixed deprecated method calls
@fabpot fabpot merged commit a6562b3 into symfony:2.3 Dec 28, 2013
@wouterj wouterj deleted the depre_flattenexcep_calls branch December 28, 2013 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wouterj @jakzal @stof @Tobion @fabpot
0