[DomCrawler]fix #9321 Crawler::addHtmlContent add gbk encoding support #9323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
| $tmpContent = @mb_convert_encoding($content, 'HTML-ENTITIES', $charset); | ||
|
|
||
| set_error_handler($previous); |
There was a problem hiding this comment.
set_error_handler() lost error_types information in previous error handler....
I can not find solution about this problem..
There was a problem hiding this comment.
you should sue restore_error_handler instead of set_error_handler($previous)
| $content = mb_convert_encoding($content, 'HTML-ENTITIES', $charset); | ||
| if (function_exists('mb_convert_encoding')) { | ||
| $hasError = false; | ||
| set_error_handler(function()use(&$hasError){ |
There was a problem hiding this comment.
should be set_error_handler(function () use (&$hasError) {
fabpot
added a commit
that referenced
this pull request
Dec 29, 2013
…ing support (bronze1man) This PR was submitted for the 2.2 branch but it was merged into the 2.3 branch instead (closes #9323). Discussion ---------- [DomCrawler]fix #9321 Crawler::addHtmlContent add gbk encoding support | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #9321 | License | MIT | Doc PR | n/a This is solution 1 in #9321 (comment) Commits ------- 30af288 fix some cs 9f20b24 use restore_error_handler instead of set_error_handler($previous) 53cb6ad [DomCrawler]fix #9321 Crawler::addHtmlContent add gbk encoding support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is solution 1 in #9321 (comment)