[Stopwatch] Fix tests on Travis (also vagrant) #9276
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But that makes the whole test suite run much slower. |
|
Yes it now takes 1.4s on my vagrant box, but when running 100 times it fails only 4 times. for i in {1..100}; do
echo "Test #${i}"
phpunit
doneI'll give you my stats without the patch... |
|
Without the patch, tests failed 89 times out of 100 on my vagrant box, with this patch only 4 times, and it just takes 1 more second. |
|
do we currently already group slow tests? if not then maybe it might be good todo this. alternatively .. we could make a sleep time multiplier configurable, we have done something similar for some basic performance tests in the PHPCR/CouchDB ODM test suites: |
9BDB
fabpot
added a commit
that referenced
this pull request
Oct 15, 2013
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #9276). Discussion ---------- [Stopwatch] Fix tests on Travis (also vagrant) Travis often fails to run tests related to the Stopwatch Component, check it yourself: - https://travis-ci.org/symfony/symfony/jobs/12340378 - https://travis-ci.org/symfony/symfony/jobs/12365787 - https://travis-ci.org/symfony/symfony/jobs/12365790 - https://travis-ci.org/symfony/symfony/jobs/12367771 - https://travis-ci.org/symfony/symfony/jobs/12367844 - https://travis-ci.org/symfony/symfony/jobs/12368619 - https://travis-ci.org/symfony/symfony/jobs/12371316 - https://travis-ci.org/symfony/symfony/jobs/12375730 This is because Travis is just slow as hell. So I just multiply the used usleep by 10. Commits ------- bf65483 Make usleep longer and simplify assertions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis often fails to run tests related to the Stopwatch Component, check it yourself:
This is because Travis is just slow as hell. So I just multiply the used usleep by 10.