[Bridge] [Propel1] Fixed guessed relations #9222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @willdurand |
|
Looks good to me. |
fabpot
added a commit
that referenced
this pull request
Oct 7, 2013
This PR was merged into the 2.2 branch. Discussion ---------- [Bridge] [Propel1] Fixed guessed relations <table> <tr><th>Q</th><th>A</th></tr> <tr><td>Bug fix</td><td>yes</td></tr> <tr><td>Feature addition</td><td>no</td></tr> <tr><td>Backwards compatibility break</td><td>no</td></tr> <tr><td>Symfony2 tests pass</td><td>yes</td></tr> <tr><td>Fixes the following tickets</td><td>N/A</td></tr> <tr><td>Todo</td><td>N/A</td></tr> <tr><td>License of the code</td><td>MIT</td></tr> <tr><td>Documentation PR</td><td>N/A</td></tr> </table> The `PropelTypeGuesser` did not match OneToMany relations properly. For example if you have a `Author` class with `Comments` attributes the guesser would guess "Comment" instead of "Comments". I added some tests to ensure the non regression. Commits ------- 0b1e95f Fixed propel guessed relations
Sign up for free
to join this conversation on GitHub.
Already have an accou
5AA5
nt?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PropelTypeGuesserdid not match OneToMany relations properly. For example if you have aAuthorclass withCommentsattributes the guesser would guess "Comment" instead of "Comments".I added some tests to ensure the non regression.