8000 Prepend Child Bundle paths before the parent by trsteel88 · Pull Request #9112 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Prepend Child Bundle paths before the parent #9112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Prepend Child Bundle paths before the parent #9112

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2ebcf66
Prepend Child Bundle paths before the parent - fixes #9085
trsteel88 Sep 24, 2013
db3a041
reverse the other of the dirs as they are prepended
trsteel88 Sep 24, 2013
75686e6
remove the prepended kernel root resources directory as you can just …
trsteel88 Sep 24, 2013
a62debb
remove method check
trsteel88 Sep 24, 2013
f3e8c6a
remove line break
trsteel88 Sep 24, 2013
59840e3
add method to sort bundles by child first. remove the need for prepen…
trsteel88 Sep 24, 2013
bbb78d3
use getPath() from bundle instance. prepend child app Resource path t…
trsteel88 Sep 24, 2013
98fc660
remove unused var
trsteel88 Sep 24, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reverse the other of the dirs as they are prepended
  • Loading branch information
@trsteel88
trsteel88 committed Sep 24, 2013
commit db3a041de8562f5a5809943b461b1aa578680818
4 changes: 2 additions & 2 deletions src/Symfony/Bundle/TwigBundle/DependencyInjection/TwigExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,11 @@ public function load(array $configs, ContainerBuilder $container)
$bundleInstance = $reflection->newInstance();

if (null !== $parentBundle = $bundleInstance->getParent()) {
if (is_dir($dir = $container->getParameter('kernel.root_dir').'/Resources/'.$bundle.'/views')) {
if (is_dir($dir = dirname($reflection->getFilename()).'/Resources/views')) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$bundleInstance->getPath() would be probably better than dirname($reflection->getFilename()).

$this->prependTwigPath($twigFilesystemLoaderDefinition, $dir, $parentBundle);
}

if (is_dir($dir = dirname($reflection->getFilename()).'/Resources/views')) {
if (is_dir($dir = $container->getParameter('kernel.root_dir').'/Resources/'.$bundle.'/views')) {
$this->prependTwigPath($twigFilesystemLoaderDefinition, $dir, $parentBundle);
}
}
Expand Down
0