8000 [HttpKernel] made request stack feature BC by Tobion · Pull Request #9059 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpKernel] made request stack feature BC #9059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2013
Merged

[HttpKernel] made request stack feature BC #9059

merged 1 commit into from
Sep 18, 2013

Conversation

Tobion
Copy link
Contributor
@Tobion Tobion commented Sep 17, 2013
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #8904 see comments
License MIT

@Tobion Tobion mentioned this pull request Sep 17, 2013
Merged
5 tasks
Tobion
Tobion reviewed Sep 17, 2013
View reviewed changes
src/Symfony/Component/HttpFoundation/RequestStack.php
*/
public function pop()
{
if (!$this->requests) {
throw new \LogicException('Unable to pop a Request as the stack is already empty.');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all other methods return null instead of throwing exception. as there is no method to check wether the stack has elements at all, pop cannot throw exception.

fabpot added a commit that referenced this pull request Sep 18, 2013
@fabpot
merged branch Tobion/request-stack-bc (PR #9059)
77d7906 
This PR was merged into the master branch.

Discussion
----------

[HttpKernel] made request stack feature BC

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #8904 see comments
| License       | MIT

Commits
-------

08a42e7 [HttpKernel] made request stack feature BC
@fabpot fabpot merged commit 08a42e7 into symfony:master Sep 18, 2013
@Tobion Tobion deleted the request-stack-bc branch September 18, 2013 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tobion @fabpot
0