Allow null values as tag attributes #9046
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -224,7 +224,7 @@ private function parseDefinition($id, $service, $file) | |||
| unset($tag['name']); | |||
|
|
|||
| foreach ($tag as $attribute => $value) { | |||
| if (!is_scalar($value)) { | |||
| if (!is_scalar($value) && !is_null($value)) { | |||
There was a problem hiding this comment.
not sure if we also want to make the change here .. but I guess it would be consistent to do so.
There was a problem hiding this comment.
+1 for consistency
Can you change the test to null !==? Also, a unit test would be good to avoid any regressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see also symfony/dependency-injection@3a194b7#commitcomment-4096394
fixes a regression see https://travis-ci.org/symfony-cmf/RoutingBundle/jobs/11362114#L165