8000 [FrameworkBundle] Added comment about http_method_override and HttpCache by kbond · Pull Request #9013 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[FrameworkBundle] Added comment about http_method_override and HttpCache #9013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2013
Merged

Conversation

kbond
Copy link
Member
@kbond kbond commented Sep 12, 2013
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #8481
License MIT
Doc PR n/a

fabpot added a commit that referenced this pull request Sep 12, 2013
This PR was merged into the master branch.

Discussion
----------

[FrameworkBundle] Added comment about http_method_override and HttpCache

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #8481
| License       | MIT
| Doc PR        | n/a

Commits
-------

52d2bdd Added comment about http_method_override and HttpCache
@fabpot fabpot closed this Sep 12, 2013
@fabpot fabpot merged commit 52d2bdd into symfony:master Sep 12, 2013
@kbond kbond deleted the patch-1 branch September 12, 2013 20:03
@@ -36,7 +36,7 @@ public function getConfigTreeBuilder()
->children()
->scalarNode('secret')->end()
->scalarNode('http_method_override')
->info("Set true to enable support for the '_method' request parameter to determine the intended HTTP method on POST requests.")
->info("Set true to enable support for the '_method' request parameter to determine the intended HTTP method on POST requests. Note: When using the HttpCache, you need to call the method in your front controller instead")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing period at the end of the sentence.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^ true, period is missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0