8000 [TwigBridge] fixed form rendering when used in a template with dynamic inheritance by fabpot · Pull Request #9010 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[TwigBridge] fixed form rendering when used in a template with dynamic inheritance #9010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2013
Merged

[TwigBridge] fixed form rendering when used in a template with dynamic inheritance #9010

merged 1 commit into from
Sep 12, 2013

Conversation

fabpot
Copy link
Member
@fabpot fabpot commented Sep 12, 2013
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #5284
License MIT
Doc PR n/a

@fabpot fabpot mentioned this pull request Sep 12, 2013
Closed
@fabpot
Copy link
Member Author
fabpot commented Sep 12, 2013

There is one caveat (not related to this fix): As the parent is dynamic, we should not cache the resource as two calls might lead to a different parent. That said, and in real-life situation, that should never occur.

fabpot added a commit that referenced this pull request Sep 12, 2013
@fabpot
merged branch fabpot/twig-form-renderer-fix (PR #9010)
8e5a9b0 
This PR was merged into the 2.2 branch.

Discussion
----------

[TwigBridge] fixed form rendering when used in a template with dynamic inheritance

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #5284
| License       | MIT
| Doc PR        | n/a

Commits
-------

4c1dbc7 [TwigBridge] fixed form rendering when used in a template with dynamic inheritance
@fabpot fabpot merged commit 4c1dbc7 into symfony:2.2 Sep 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fabpot
0