[2.3][Form] Fixed expanded choice field to be marked invalid when unknown choices are submitted #8981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e they don't offer any performance benefit
…choices are submitted
Merged
3 tasks
fabpot
added a commit
that referenced
this pull request
Sep 10, 2013
This PR was merged into the 2.3 branch. Discussion ---------- [2.3][Form] Fixed expanded choice field to be marked invalid when unknown choices are submitted Same as #7940, rebased onto 2.3. Commits ------- 7879f07 [DoctrineBridge] Improved test coverage of EntityChoiceList 58e7c10 [Form] Improved test coverage of ChoiceList classes 9542d72 [Form] Fixed expanded choice field to be marked invalid when unknown choices are submitted 72b8807 [Form] Fixed ChoiceList::get*By*() methods to preserve order and array keys e1bf07f [Form] Removed usage of the ChoiceList::getIndicesFor*() methods where they don't offer any performance benefit
|
It look's like this pull request created an issue in EntityChoiceList::getChoicesForValues - it doesn't check case with empty array, so it can cause as exception when there is no entities and it generates SQL with condition "id in ()". |
|
Thanks for reporting @yshyshkin. I added a test case before removing the appropriate code, which didn't fail after removing. Going to investigate... |
|
@yshyshkin I can't reproduce the issue. Could it be that updating Doctrine fixes this bug? |
|
@yshyshkin Ah in fact I can reproduce it, it just didn't fail with an exception as I expected. |
|
Fixed in #9001 |
|
@bschussek Thank you, it should help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add
2F2D
this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #7940, rebased onto 2.3.