8000 [FrameworkBundle] Added configuration for additionnal request formats by gquemener · Pull Request #8944 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Added configuration for additionnal request formats #8944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

[FrameworkBundle] Added configuration for additionnal request formats #8944

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ebc22f5
[FrameworkBundle] Added configuration for additionnal request formats
gquemener Sep 6, 2013
c50d284
[FrameworkBundle] Fixed mispelled "additional" word
gquemener Sep 6, 2013
f019dec
[FrameworkBundle] Fixed xml configuration when adding request formats
gquemener Sep 6, 2013
f92b188
[FrameworkBundle] Added request tag inside FrameworkBundle xsd
gquemener Sep 6, 2013
3cab8e2
[FrameworkBundle] Removed top level id of format listener
gquemener Sep 7, 2013
2c5adea
[FrameworkBundle] Fixed xml schema for embedding mime-types into format
gquemener Sep 7, 2013
5165d10
[FrameworkBundle] Load the formats listener only if some are configured
gquemener Sep 7, 2013
b41388e
[FrameworkBundle] Added config fixtures for request key
gquemener Sep 7, 2013
05ccbdb
[FrameworkBundle] Added config fixtures for empty request formats
gquemener Sep 7, 2013
f769076
[FrameworkBundle] Added missing php doc
gquemener Sep 7, 2013
5f1dbfd
Merge branch 'master' of github.com:symfony/symfony
gquemener Dec 24, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[FrameworkBundle] Fixed xml configuration when adding request formats
  • Loading branch information
@gquemener
gquemener committed Sep 6, 2013
commit f019dec6339342c196fce8d7332e0cd36922cdcf
1 change: 1 addition & 0 deletions src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,7 @@ private function addRequestSection(ArrayNodeDefinition $rootNode)
->arrayNode('request')
->info('request configuration')
->canBeUnset()
->fixXmlConfig('additionnal_format')
->children()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing the ->fixXmlConfig('additional_format') call to make the prototyped node work properly for XML configs

->arrayNode('additional_formats')
->prototype('array')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are missing useAttributeAsKey to make it an associative array

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are still missing the call to useAttributeAsKey. Please add a test using this feature in different formats to see that it is broken currently

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks, will do soon

Expand Down
0